Simon Willison’s Weblog

Subscribe
Atom feed for codereview

3 items tagged “codereview”

2019

In general, reviewers should favor approving a CL [code review] once it is in a state where it definitely improves the overall code health of the system being worked on, even if the CL isn’t perfect.

Google Standard of Code Review

# 28th November 2019, 5:40 am / codereview, google

2010

Design and code review requested for Django string signing / signed cookies. Do you know your way around web app security and cryptography (in particular signing things using hmac and sha1)? We’d appreciate your help reviewing the usage of these concepts in Django’s proposed string signing and signed cookie implementations.

# 4th January 2010, 1:24 pm / codereview, cryptography, django, hashing, hmac, python, security, sha1

2007

Review Board. VMWare release a slick looking Django-powered code review system, with hooks in to Subversion and Perforce.

# 31st May 2007, 8:32 am / codereview, django, perforce, subversion, vmware